Skip to content

Commit

Permalink
Don't double-filter replication jobs
Browse files Browse the repository at this point in the history
ObjectReplicator.collect_jobs() takes and correctly applies the
various overrides, so there's no need to check the returned jobs
against the overrides.

Change-Id: I2a59b26410d1732a5f2c8f1f32e397d77550860e
  • Loading branch information
smerritt committed Mar 13, 2018
1 parent 0a4d1b7 commit de38b72
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions swift/obj/replicator.py
Expand Up @@ -745,11 +745,6 @@ def replicate(self, override_devices=None, override_partitions=None,
override_policies=override_policies)
for job in jobs:
current_nodes = job['nodes']
if override_devices and job['device'] not in override_devices:
continue
if override_partitions and \
job['partition'] not in override_partitions:
continue
dev_path = check_drive(self.devices_dir, job['device'],
self.mount_check)
if not dev_path:
Expand Down

0 comments on commit de38b72

Please sign in to comment.