Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use PCRE instead of Python's re for RedirectMatch tests
Previously, RedirectMatch rules were evaluated using Python's re regexp module. However, Apache httpd uses the PCRE library for evaluating regular expressions,[1] and there are subtle differences between the Python and PCRE implementations. Using the PCRE library itself (via the pcre-python binding) provides more representative results, and hence more confidence to the user that any rules that pass whereto's tests will work in the same way in a real Apache configuration. [1] https://httpd.apache.org/docs/trunk/glossary.html#regex Change-Id: Ibef3376d9da0688d0c97f5837dacc5b7cc52431c
- Loading branch information
Showing
6 changed files
with
35 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
libpcre3-dev [platform:dpkg] | ||
pcre-devel [platform:rpm] | ||
dev-libs/libpcre [platform:gentoo] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
features: | ||
- whereto now uses the PCRE library - the same regex library used by | ||
mod_alias - for compiling regular expressions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ | |
# process, which may cause wedges in the gate later. | ||
|
||
pbr>=2.0 # Apache-2.0 | ||
python-pcre |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters