Show error to users if for some reason the file could not be removed

openstad · Sep 13, 2023 · 41dfacf · 41dfacf · github-actions · Sep 13, 2023
1 parent d6e3004
commit 41dfacf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/cms/lib/modules/resource-form-widgets/lib/budget.js b/packages/cms/lib/modules/resource-form-widgets/lib/budget.js
@@ -56,12 +56,16 @@ module.exports = async function(self, options) {
 
                 try {
                     if (fs.existsSync(attachmentsPath)) {
-                        console.log("Removing the file")
+                        console.log("Removing the file");
                         fs.rmSync(attachmentsPath, { recursive: true });
                     }
                 }
                 catch(e) {
-                    console.log("The file could not be deleted");
+                    return res.status(500).send(
+                        JSON.stringify({
+                            msg: "Het bestand kon niet verwijderd worden, probeer het nog eens.",
+                        })
+                    );
                 }
             }
 

diff --git a/packages/cms/lib/modules/resource-form-widgets/public/js/main.js b/packages/cms/lib/modules/resource-form-widgets/public/js/main.js
@@ -483,6 +483,9 @@ function deleteBudgetDocument(name, date, id, siteUrl) {
     data: { name: name, date:date, id: id},
     success: function(data) {
         location.reload();
+    },
+    error: function(e) {
+      alert(e.responseJSON.msg);
     }
   });
 }