Feature/prefix tag container with unique #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanR01
reviewed
Jun 12, 2023
.../lib/modules/resource-overview-widgets/views/includes/controls/tag-includes/tags_desktop.njk
Show resolved
Hide resolved
…des/controls/tag-includes/tags_desktop.njk Set tagGroupPrefix to empty string on desktop Co-authored-by: IanR01 <IanR01@users.noreply.github.com>
IanR01
reviewed
Jun 14, 2023
...es/resource-overview-widgets/views/includes/controls/tag-includes/group-variants/grouped.njk
Outdated
Show resolved
Hide resolved
…des/controls/tag-includes/group-variants/grouped.njk Co-authored-by: IanR01 <IanR01@users.noreply.github.com>
LorenzoJokhan
deleted the
feature/prefix-tag-container-with-unique-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split tags.html up in reusable and manageable includes.
Add a specific prefix on tag-groups for mobile and desktop-resource-form-widget
Add id and class on taggroup for styling
Bij de resource-overview-widget zijn de volgende selectors aanwezig:
Voor mobile als er gekozen is voor gegroepeerde weergave :
id: "mobile-tag-group-"
class: "mobile-tag-group"
titel van de groep: mobile-tag-group-title
Voor mobile als er gekozen is voor een NIET-gegroepeerde weergave :
id: mobile-tag-group-none
class: "mobile-tag-group-none"
Voor mobile als er gekozen is voor een specifieke-type weergave :
id: mobile-tag-group-
class: "mobile-tag-group-"
Om voor desktop te stylen. Verwijder de prefix mobile-