Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID: Vote names saved with a trailing "(name") #1511

Closed
mshenfield opened this issue Mar 16, 2017 · 5 comments
Closed

ID: Vote names saved with a trailing "(name") #1511

mshenfield opened this issue Mar 16, 2017 · 5 comments

Comments

@mshenfield
Copy link
Contributor

mshenfield commented Mar 16, 2017

The ID bill scraper is saving names with a trailing "(name)", e.g. "(Lacey)"

Some examples:
Mendive(Mendive), Smith(Nye), Bock(Burgoyne), Rubel(Green), Horman(Reed), Smith(Lacey)

This is causing the vote to come back with a null leg_id, since the name cannot be matched back to a known legislator.

Shivansh-Bajaj added a commit to Shivansh-Bajaj/openstates that referenced this issue Mar 16, 2017
jamesturk added a commit that referenced this issue Mar 16, 2017
@jamesturk jamesturk reopened this Mar 16, 2017
@jamesturk
Copy link
Member

pending run

@Shivansh-Bajaj
Copy link
Contributor

@jamesturk could you elaborate what we need to convert

@jamesturk
Copy link
Member

sorry about that, was a stray comment that I didn't realize I posted

@jamesturk
Copy link
Member

@mshenfield can you verify this looks OK in the data now?

@mshenfield
Copy link
Contributor Author

Running locally, verified that the examples provided are no longer present in the the votes

db.votes.find({"state": "id", $or: [{"yes_votes": { $elemMatch: {"name": "Mendive(Mendive)"}}}, {"other_votes": { $elemMatch: {"name": "Mendive(Mendive)"}}}, {"no_votes": { $elemMatch: {"name": "Mendive(Mendive)"}}}]})

and that corresponding "Mendive" votes are present:

db.votes.find({"state": "id", $or: [{"yes_votes": { $elemMatch: {"name": "Mendive"}}}, {"other_votes": { $elemMatch: {"name": "Mendive"}}}, {"no_votes": { $elemMatch: {"name": "Mendive"}}}]})

@ghost ghost removed the fixed pending run label Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants