Comments in blog posts only #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ellessenne for the proposal! |
|
@ywang-gilead what do you think? |
|
I think we could remove it from the homepage and keep it on the other pages. |
|
@ywang-gilead Ah good idea. @ellessenne is that possible - just remove it from the landing page, and keep on the other pages? |
|
I think so, let me try! |
|
Update: I moved back the Giscus configuration to |
danielinteractive
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR moves the Giscus setup to
blog/_metadata.yaml, thus enabling comments in blog posts only. The main idea was to remove it from the homepage, as I don't think it was very useful – what do you think? Should comments stay in other pages?Alessandro