Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move modulestates to schema initialization #450

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

karenc
Copy link
Contributor

@karenc karenc commented Aug 4, 2016

Module states should really be part of the database initialization, it's
not data to be added later. It is necessary for the application, so
moving it to cnxarchive/sql/schema/.

@karenc
Copy link
Contributor Author

karenc commented Aug 4, 2016

See also openstax/cnx-publishing#136

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.479% when pulling e1bfd6b on move-modulestates-to-schema-initialization into 0990a75 on master.

@mmulich
Copy link
Contributor

mmulich commented Aug 4, 2016

For the sake of consistency, could you put these in a file within the schema/constants directory?

For example, the schema/constants/roles.sql contains inserts for the roles table.

@karenc karenc force-pushed the move-modulestates-to-schema-initialization branch from e1bfd6b to 9c8559e Compare August 4, 2016 05:58
@karenc
Copy link
Contributor Author

karenc commented Aug 4, 2016

Oh I didn't realize we have a schema/constants directory... 😓
I've moved the file.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.479% when pulling 9c8559e on move-modulestates-to-schema-initialization into 0990a75 on master.

Module states should really be part of the database initialization, it's
not data to be added later.  It is necessary for the application, so
moving it to ``cnxarchive/sql/schema/``.
@mmulich mmulich force-pushed the move-modulestates-to-schema-initialization branch from 9c8559e to 265770c Compare August 4, 2016 17:38
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.479% when pulling 265770c on move-modulestates-to-schema-initialization into 0990a75 on master.

@mmulich mmulich merged commit b5784e4 into master Aug 4, 2016
@mmulich mmulich deleted the move-modulestates-to-schema-initialization branch August 4, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants