Skip to content
This repository has been archived by the owner on Jun 27, 2020. It is now read-only.

Rewrite setup #9

Merged
merged 8 commits into from Feb 19, 2019
Merged

Rewrite setup #9

merged 8 commits into from Feb 19, 2019

Conversation

tomjw64
Copy link
Contributor

@tomjw64 tomjw64 commented Feb 7, 2019

Reorganized the package to be installed with pip. Uses setuptools with setup.py instead of a standalone setup.sh for more flexibility with regards to virtualenv and --user installs. It was then fairly easy to add the content-copy command in the process while maintaining backwards compatibility using the ./content-copy executable.
In all:

  • rewrote setup,
  • adds a content-copy command during setup but doesn't remove the old way
  • allows setup with a virtualenv or without with --user
  • updated docs to match

@staxly staxly bot added this to In progress in All Openstax Feb 7, 2019
@tomjw64 tomjw64 changed the title Rewrite setup, add command 'content-copy', allow setup with either --user or virtualenv, update docs WIP Rewrite setup, add command 'content-copy', allow setup with either --user or virtualenv, update docs Feb 7, 2019
@tomjw64 tomjw64 changed the title WIP Rewrite setup, add command 'content-copy', allow setup with either --user or virtualenv, update docs Rewrite setup, add command 'content-copy', allow setup with either --user or virtualenv, update docs Feb 7, 2019
@tomjw64 tomjw64 changed the title Rewrite setup, add command 'content-copy', allow setup with either --user or virtualenv, update docs Rewrite setup Feb 7, 2019
@tomjw64 tomjw64 added this to the v1.3 milestone Feb 7, 2019
Copy link
Contributor

@karenc karenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@edwoodward edwoodward merged commit dbbe321 into master Feb 19, 2019
@edwoodward edwoodward deleted the setuptools-setup branch February 19, 2019 16:40
@staxly staxly bot moved this from In progress to Done in All Openstax Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
All Openstax
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants