salesforce faculty verification #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich-hart
force-pushed
the
salesforce
branch
2 times, most recently
from
8079651
to
e459a76
Compare
| security_token=settings.SALES_SECURITY_TOKEN) | ||
|
|
||
|
|
||
| def faculty_status(accounts_id): |
There was a problem hiding this comment.
Leaving a reminder to myself to add error handling here.
There was a problem hiding this comment.
Yeah - there was a question from Kathi about what would happen if SF was down - how will the app handle that? This should be addressed in the error handling.
rich-hart
force-pushed
the
salesforce
branch
4 times, most recently
from
0742d51
to
a656820
Compare
| logger.error("{0}('{1}')".format(error_type,error_message)) | ||
| return False | ||
|
|
||
| def faculty_status(self,accounts_id): |
There was a problem hiding this comment.
Can you add spaces after the commas in this file to maintain readability?
There was a problem hiding this comment.
Sure thing. I'll make a PEP8 update
|
I am getting the following error when I hit /api/user: I see you added a template to local.py.example - how do I get the keys to test this? |
|
I just sent you the keys using lastpass. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the basic functionality of connecting to salesforce. Several features still need to be implemented, .e.g. updating the authentication method to use OAuth 2.0, tracking salesforce usage statistics,
encrypted keys for travis testing,etc.