Downgrade lodash to 3.10 #1299
Closed
Downgrade lodash to 3.10 #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to version 4.x breaks the calendar. It's getEventHandlers uses _.pick with a funtion on props to select the valid props. Lodash 4.x has removed the ability to use a function with _.pick, and requires the use of _.pickBy for that. Because of this, the onClick prop isn't passed to the Day component and days cannot be clicked.
|
Closing since the issue was that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this also happened in #1027 (insert witty comment about frailty of memory here)
Upgrading to version 4.x breaks the calendar. It's getEventHandlers
uses _.pick with a funtion on props to select the valid props.
Lodash 4.x has removed the ability to use a function with _.pick, and
requires the use of _.pickBy for that.
Because of this, the onClick prop isn't passed to the Day component and
days cannot be clicked.