lateness icon should show for college readings and homeworks #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should show for both readings and homeworks, whereas they should not show for high school courses
nathanstitt
reviewed
Feb 7, 2017
| else | ||
| <GenericEventRow courseId=@props.courseId key={event.id} event={event}/> | ||
| <GenericEventRow {...rowProps}/> | ||
|
|
There was a problem hiding this comment.
Since all components are receiving the same props, how about just setting a variable with the component class in the switch, i.e.
Row = switch event.type
when 'reading' then ReadingRow
when 'homework' then HomeworkRow
...and then later render: <Row courseId={@props.courseId} ... >
|
Thanks @pandafulmanda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass in isCollege for event row lateness icon logic -- lateness icon should show for both readings and homeworks, whereas they should not show for high school courses
High school late readings
College late readings