Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style teacher calendar like the student dashboard #302

Merged
merged 7 commits into from May 25, 2015

Conversation

nathanstitt
Copy link
Member

With cursor hovered over Add iReading:

screen shot 2015-05-22 at 3 58 50 pm

@nathanstitt nathanstitt changed the title WIP: Abstract booksplash styles into a shared version WIP: Style teacher calendar like the student dashboard May 22, 2015
@pandafulmanda
Copy link
Contributor

👍

@philschatz
Copy link
Member

Can you remove the "Task Plans for Course 1" panel header too? that'll fix another pivotal ticket (which I think is assigned to you too)

@nathanstitt
Copy link
Member Author

Yeah the mockup doesn't have that so I've removed it. New screenshot coming up shortly

Increasing the target area for clicks is a bit more accessible
@nathanstitt
Copy link
Member Author

@pandafulmanda Your CourseAddMenuMixin came through big time!

It was ridiculous easy to add the "Add Assignment" button

This works better since it'll allow the top element directly under
`tutor-booksplash-background` to be targeted.
@nathanstitt nathanstitt changed the title WIP: Style teacher calendar like the student dashboard Style teacher calendar like the student dashboard May 22, 2015
text-align: center;
font-size: 300px;
line-height: 200px;
font-family: 'HelveticaNeue-Bold', 'Helvetica Neue Bold', 'Helvetica Neue';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in typography.less?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. This is the only place that I see Helvetica being used. grep -r Helvetica only returns this at least. Is still worthwhile to have it available globally do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Helvetica is not included as a font I think it should either:

  1. be included in resources/fonts (assuming we have rights to use it) and include it in typography.less
  2. include a different font

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe it's a proprietary font that's included on OS X only. I suppose we could license it but is probably better to find an alternative.

@Fredasaurus any thoughts on substituting a different font for HelveticaNeue here? I'd used it because here because it was in the original mockup. I'm not sure that was intended or perhaps it was just the default for your mockup tool. I'd suggest using Lato Bold or we could bundle a different Google font of your choosing.

philschatz added a commit that referenced this pull request May 25, 2015
Style teacher calendar like the student dashboard
@philschatz philschatz merged commit 37859fe into master May 25, 2015
@philschatz philschatz deleted the teacher-calendar-bg branch May 25, 2015 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants