New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style teacher calendar like the student dashboard #302
Conversation
👍 |
Can you remove the "Task Plans for Course 1" panel header too? that'll fix another pivotal ticket (which I think is assigned to you too) |
Yeah the mockup doesn't have that so I've removed it. New screenshot coming up shortly |
Increasing the target area for clicks is a bit more accessible
@pandafulmanda Your It was ridiculous easy to add the "Add Assignment" button |
This works better since it'll allow the top element directly under `tutor-booksplash-background` to be targeted.
3f0d13d
to
808c889
Compare
text-align: center; | ||
font-size: 300px; | ||
line-height: 200px; | ||
font-family: 'HelveticaNeue-Bold', 'Helvetica Neue Bold', 'Helvetica Neue'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in typography.less
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. This is the only place that I see Helvetica being used. grep -r Helvetica
only returns this at least. Is still worthwhile to have it available globally do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Helvetica is not included as a font I think it should either:
- be included in
resources/fonts
(assuming we have rights to use it) and include it intypography.less
- include a different font
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe it's a proprietary font that's included on OS X only. I suppose we could license it but is probably better to find an alternative.
@Fredasaurus any thoughts on substituting a different font for HelveticaNeue here? I'd used it because here because it was in the original mockup. I'm not sure that was intended or perhaps it was just the default for your mockup tool. I'd suggest using Lato Bold or we could bundle a different Google font of your choosing.
Style teacher calendar like the student dashboard
With cursor hovered over
Add iReading
: