Student Scores: adds tooltips, ellipsis and scale/wrap to tabs #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the tab width (and ellipses) not possible using just CSS? |
|
For example, something like: .period-tab {
display: inline-block;
max-width: 100px;
overflow-x: hidden;
text-overflow: ellipses;
white-space: nowrap;
}Otherwise, can you add tests? |
philschatz
changed the title
| @@ -80,6 +82,14 @@ | |||
| a { | |||
| font-weight: 400; | |||
| color: @tutor-neutral !important; | |||
| span { | |||
There was a problem hiding this comment.
Could you add a class to this element so it is not selecting span? Maybe react-bootstrap does not have an easy way to do this though
philschatz
added a commit
that referenced
this pull request
Feb 23, 2016
Student Scores: adds tooltips, ellipsis and scale/wrap to tabs
| li { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| li.tab-item-period { | ||
| text-align: center; |
There was a problem hiding this comment.
tutor-nav-tabs are used on other things than periods. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding task: https://www.pivotaltracker.com/story/show/112365737
added tooltips, ellipsis and scale/wrap to tabs to allow for longer names and more periods