Output from client.shell returns [object Object] when toString() is called on it

[op1ekun]

Hi guys, I run into a strange issue:

client.shell(serial, 'ifconfig wlan0', function adbCommandCb(err, output) {
    console.log(output.toString('utf-8'));
}

The console.log produces [object Object].
I have already tried using just plain .toString(), but the result is the same.

I will try Promise version any (it fits in the code better than the callback one).

Version of adbkit: 2.3.1
Node: 0.10.40
System: Windows Server 2012 R2

Thanks!

[sorccu]

That's correct behavior. The shell() command supports long-running commands such as while loops and logcat, so it needs to stream the output before it finishes. See https://github.com/openstf/adbkit#example for example usage.

[op1ekun]

Read test failed...
I completely missed it.
Thanks!

[op1ekun]

Actually now I know why I got confused.

The docs for client.shell say:
output - A Buffer containing all the output. Call output.toString('utf-8') to get a readable String from it.

However output here is a Stream. To get the Buffer you either have to listen to Stream events or use your util.readAll.

I was trying hard to read the Buffer which wasn't there yet ;)