fix sync.stat() failure for multibyte paths #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
client.stat() fails for files with multi-byte filename like "あああ.txt" (japanese filename)
This will fix the problem.
Root Cause:
In _sendCommandWithArg method, it uses arg.length for the binary payload size of arg. But if arg is multi-byte string, arg.length is wrong to be used for the purpose, because it is the count of characters and not the size of bytes.
Solution
Use Buffer.byteLength(arg, 'utf-8') as the binary payload size of arg.
see: https://nodejs.org/api/buffer.html#buffer_class_method_buffer_bytelength_string_encoding
Related
#86 may be fixed with this fix.