Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Screen Recording using 'screenrecord' feature from adb #1078

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RzRnt
Copy link

@RzRnt RzRnt commented Jul 18, 2019

Hello, I'm trying to add a new feature to record screen, need feedback about this feature, maybe you guys already thought about it and choose to not implement it with a good reason that I don't know

  • Add a new tab to 'Screen Recording', using the same behaviour with screenshots tab
  • only support device that support 'screenrecord' feature

Screenrecord only able to record up to 3 minutes

Screen Shot 2019-07-22 at 11 37 38

need to be implemented later

  • recording config, all configurable attribute in screenrecord (time limit, bit depth, etc)

}))

it('should ...', inject(function() {
expect(1).toEqual(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like autogenerated test stub.

Copy link
Author

@RzRnt RzRnt Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just copy it from screenshots folder, yeah looks like it's auto generated file, i just thought it's kind of reminder to create a test, should i delete it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, of course it is better to write a proper test if it is possible.

@shri-0509
Copy link

shri-0509 commented Jul 25, 2019

Just a thought, since adb screenrecord has 3min limit, can't we use webrtc(mediarecorder) and record the screen displayed on device control page and show it to the user.
Any inputs on the above @koral--

@thinkhy
Copy link
Member

thinkhy commented Jul 27, 2019

Just a thought, since adb screenrecord has 3min limit, can't we use webrtc(mediarecorder) and record the screen displayed on device control page and show it to the user.
Any inputs on the above @koral--

it would works as scrcpy does, indeed it could work around the 3min limit.

@RzRnt
Copy link
Author

RzRnt commented Jul 30, 2019

scrcpy use ffmpeg to record right? cmiiw
another workaround for 3 min limit is to merge multiple videos into one via base64 format(haven't tried) but i don't know if it'll give a smooth transition between video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants