Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61 add basic working search within Poland's bounds #71

Conversation

sabman
Copy link
Contributor

@sabman sabman commented Mar 3, 2022

Work for #61

@jsanz
Copy link
Contributor

jsanz commented Mar 3, 2022

@Mordechai23 @sabman not sure if you are accepting reviews and other types of contributions, but if it helps in any way, I've tested this PR and the search bar renders without issues and accepts inputs in several languages, nice job!

@Mordechai23 Mordechai23 requested a review from ttomasz March 3, 2022 11:41
Copy link
Collaborator

@pmatejko pmatejko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested it and it looks like a nice feature, thanks for contribution :)

@Ancymonek Ancymonek self-requested a review March 4, 2022 16:49
@Ancymonek Ancymonek merged commit e3cb4d4 into openstreetmap-polska:main Mar 4, 2022
@jsanz
Copy link
Contributor

jsanz commented Mar 4, 2022

Would it make sense to do a follow up enhancement for this feature adding results to the search bar coming from the vector layers in the overlay?

I don't know if it's useful, if all vector data is coming from OSM, hence nominatim would pick up the same results anyways.

@Mordechai23
Copy link
Collaborator

Mordechai23 commented Mar 4, 2022

I don't know if it's useful, if all vector data is coming from OSM, hence nominatim would pick up the same results anyways.

The donation drop points layer
obraz
contains manually added data, not present in OSM (It wouldnt make sense to add those points there anyway) . I tried to keep it compatible with the osm-style tagging, so they have attributes like name=* , description=* , addr=* , etc.

Possibility to search for it would be really nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants