Skip to content

Commit

Permalink
Disable OAuth 1.0 support
Browse files Browse the repository at this point in the history
  • Loading branch information
@tomhughes
tomhughes committed Feb 8, 2024
1 parent a3d2063 commit 4d161f9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cookbooks/web/resources/rails_port.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,8 @@
"max_request_area" => node[:web][:max_request_area],
"max_number_of_nodes" => node[:web][:max_number_of_nodes],
"max_number_of_way_nodes" => node[:web][:max_number_of_way_nodes],
"max_number_of_relation_members" => node[:web][:max_number_of_relation_members]
"max_number_of_relation_members" => node[:web][:max_number_of_relation_members],
"oauth_10_support" => false
)

if new_resource.memcache_servers
Expand Down

2 comments on commit 4d161f9

@mmd-osm
Copy link
Contributor

@mmd-osm mmd-osm commented on 4d161f9 Feb 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is relevant for OAuth 1.0 only, (not 1.0a), right?

As FYI: It seems the login on https://osm-internal.download.geofabrik.de is no longer working now. After authorizing the request, a verification code is shown on the screen, rather than redirecting back to Geofabrik. Maybe @woodpeck could double check this.

Authorization request allowed
You have granted application Geofabrik Downloads access to your account.
The verification code is xxxx.

@tomhughes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is only disabling 1.0 and should have no effect on 1.0a at all. Existing tokens should also be fine you just can't issue new ones via the 1.0 flow.

Please sign in to comment.