Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide turn restriction UI from highway=crossing for footway #10222

Open
tordans opened this issue Apr 26, 2024 · 3 comments
Open

Hide turn restriction UI from highway=crossing for footway #10222

tordans opened this issue Apr 26, 2024 · 3 comments

Comments

@tordans
Copy link
Collaborator

tordans commented Apr 26, 2024

URL

https://ideditor.netlify.app/#background=Bing&disable_features=boundaries&id=n8677399770&locale=en&map=20.00/52.28422/13.53982

How to reproduce the issue?

  1. open https://ideditor.netlify.app/#background=Bing&disable_features=boundaries&id=n8677399770&locale=en&map=20.00/52.28422/13.53982
  2. see the turn restriction UI which does not make any sense for this node
    image

This actually allows to create "no u turn" restrictions on the crossing node:

image

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Development version at ideditor.netlify.app

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

Chrome

@RudyTheDev
Copy link
Contributor

I don't think this is related to crossings specifically. You can get the turn restriction UI for any place where highways meet even when those highways are not supposed to appear in the UI.

@Dimitar5555
Copy link
Contributor

See #9983

@tordans
Copy link
Collaborator Author

tordans commented Apr 30, 2024

See #9983

Thanks @Dimitar5555 this could very well be a regression in ea47581
Looking at the same node in Rapid (which does not have this change) the Turn-Restriction UI does not show up https://rapideditor.org/canary#map=20.00/52.28422/13.53982&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=n8677399770&locale=en

  • Update: I learned that Rapid does not have the turn restriction UI at all … so that test is not helpful :-)

@tyrasd I think ea47581 should be reverted and the corresponding issue reopened. Having the UI show up too often is worse then having an edge case where it does not show at all, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants