Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector data #3742

Closed
bhousel opened this issue Jan 11, 2017 · 10 comments
Closed

Vector data #3742

bhousel opened this issue Jan 11, 2017 · 10 comments
Assignees
Labels
new-feature A new feature for iD
Projects

Comments

@bhousel
Copy link
Member

bhousel commented Jan 11, 2017

We will need to support vector tiled data for #3152 anyway, but there are other vector sources (e.g. QA layers) that would be great to bring into iD.

@bhousel bhousel added the new-feature A new feature for iD label Jan 11, 2017
@pnorman
Copy link
Contributor

pnorman commented Jan 12, 2017

We will need to support vector tiled data for #3152 anyway, but there are other vector sources (e.g. QA layers) that would be great to bring into iD.

There's lots of types of vector layers, what are we looking at supporting?

@bhousel
Copy link
Member Author

bhousel commented Jan 12, 2017

There's lots of types of vector layers, what are we looking at supporting?

Not sure yet. It might be worth having something like (or built into) editor-layer-index but for vector layers that are useful for editing. This ticket is just to kick around ideas, and also to track that we need something like vector-tile-js.

@bhousel bhousel added the priority A top priority issue that has a big impact or matter most to new mappers label May 8, 2017
@bhousel bhousel added this to Other Priorities in Priorities Jul 6, 2017
@slibby
Copy link
Contributor

slibby commented Jul 25, 2017

#4164 provides a starting point for bringing in vector QA layers from ArcGIS-based services, if that is of interest. Not vector tiles, but along the same lines and I think the implementation (in the Map Data expando-tab) could be similar. #3452 also mentions this and might be one way that #4164 could be helpful to start (read-only QA layers from ArcGIS sources).

@bhousel
Copy link
Member Author

bhousel commented Feb 21, 2018

CC @kriscarle for visibility - I proposed this as a GSoC project, and would be great to get this support into iD sometime soon.

@mmd-osm
Copy link
Contributor

mmd-osm commented Apr 29, 2018

Just cross linking: https://www.openstreetmap.org/user/Princi%20Vershwal/diary/43802

@vershwal
Copy link
Collaborator

The first step towards supporting vector tiled data is that a user can add a URL and have the vector tiles show up on the screen. It will look something like this :

screen_shot_2018-05-23_at_6 34 08_pm

For this, I have added another layer 'mvt'. Currently, it will support .pbf(Protocolbuffer Binary Format) and .mvt(Mapbox Vector Tiles) format. These files contain data in Protocolbuffer binary format which is converted to geojson using mapbox's vector-tile-js and this data is passed directly to the D3 draw functions to show up the tiles on the screen.
All the code related to this will be here.

@vershwal
Copy link
Collaborator

@bhousel bhousel assigned vershwal and unassigned kepta Jun 29, 2018
@bhousel
Copy link
Member Author

bhousel commented Aug 26, 2018

This happened 🎉

@bhousel bhousel closed this as completed Aug 26, 2018
@bhousel bhousel removed the priority A top priority issue that has a big impact or matter most to new mappers label Aug 26, 2018
@sahithiduddukuri
Copy link

I have tried the first step towards supporting vector tiled data is that a user can add a URL and have the vector tiles show up on the screen. It worked and it displayed as :
Screenshot from 2020-01-09 11-16-06

but the problem am facing is it is not loading on specific lat and long where it has to be. can you help me to fix this problem

@quincylvania
Copy link
Collaborator

but the problem am facing is it is not loading on specific lat and long where it has to be.

@sahithiduddukuri Hmm I'm guessing that your data does not match the expected projection. Make sure it's in WGS84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new feature for iD
Projects
No open projects
Priorities
Other Priorities
Development

No branches or pull requests

8 participants