Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload warning for building or other feature connected to road/lake etc #3859

Closed
aawiseman opened this issue Feb 23, 2017 · 7 comments
Closed

Comments

@aawiseman
Copy link

aawiseman commented Feb 23, 2017

I've seen this a lot at humanitarian mapathons, because of the snapping sometimes buildings get attached to other features they shouldn't be attached to, like roads, lakes, and so on. This could sometimes be ok (like a tunnel or something) but maybe a warning would be good, to at least look at them and disconnect them.

@aawiseman
Copy link
Author

aawiseman commented Feb 23, 2017

This is related to point 6 in #3130 (but I explained it more here.) It's not something caught by the JOSM validation tool either so it makes it hard to find aside from just looking around.

@pnorman
Copy link
Contributor

pnorman commented Feb 26, 2017

Are the users

  • not aware of what's happening;
  • not aware it's normally wrong;
  • or, not aware of how to fix it?

@bhousel
Copy link
Member

bhousel commented Feb 27, 2017

So this is the kind of validation that I'm hesitant to add to iD because it 1. Isn't always wrong, 2. doesn't really damage the map (at least not like connectivity errors or large feature edits that dirty a lot of tiles). I'm ok with users adding things that are a little bit wrong.

I'm starting to think that the most important thing I can do to improve new mappers edit quality is an overhaul of the walkthrough. I have a bunch of tickets already tagged walkthrough-help, but I'd really like to extend the walkthrough significantly and refresh the area where it occurs, and give a bit more guidance on basic OSM etiquette.

@geowOSM
Copy link

geowOSM commented Mar 9, 2017

Are the users
not aware of what's happening;
not aware it's normally wrong;
or, not aware of how to fix it?

Most mappers might be aware that unintentional snapping feels "wrong" somehow. Essentially they are unable to fix it and IMHO more important - they are not aware of how to prevent it, by alt + mouse click.

Maybe some basic shortcuts could be added to the documentation and/or a link to http://wiki.openstreetmap.org/wiki/ID/Shortcuts

@manfredbrandl
Copy link
Contributor

Please do not warn when path are connected to entrances of buildings, see #3906 .

@aawiseman
Copy link
Author

I think changing the walkthrough and documentation is a good idea, I wasn't aware of the alt- thing and I've been using iD for a long time.

@bhousel
Copy link
Member

bhousel commented Mar 21, 2017

Closing here and I'll work this week on walkthrough improvements.

@bhousel bhousel closed this as completed Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants