Support more keys in the access=* field

[Locke]

A user struggled to update access tags, as "motorcar" isn't visible in the upper part of the editor.

Initially motor_vehicle=agricultural and motorcar=no were set. As he couldn't see motorcar in the upper editor he couldn't change it. (In later attempts he added access=yes, foot=yes, motor_vehicle=yes, bicycle=yes and horse=yes which all had no effect to the more specific tag motorcar).

I suggest to add more possible tags, e.g. everything from https://wiki.openstreetmap.org/wiki/Key:access#Transport_mode_restrictions . As just adding everything would be too much I think most keys should be hidden with a (+) icon which opens a tree.

Also, the default (grayed out "yes") needs to be updated depending on higher access tags: When a way has vehicle=no motor_vehicle=destination the default value of bicycle is still displayed as grayed out "yes", however it should be "no" as bicycle is included in vehicle. As I see it from #2213 only the value of "access" is inherited and not "vehicle".

[freakyuser-osm]

I think hgv should be added as an preset to the access presets in id. This way it's easier for beginners to map truck access restrictions.

(See: #3946)

[bhousel]

I suggest to add more possible tags, e.g. everything from https://wiki.openstreetmap.org/wiki/Key:access#Transport_mode_restrictions . As just adding everything would be too much I think most keys should be hidden with a (+) icon which opens a tree.

I like this suggestion because it would let us support more keys, and at the same time we could drop the existing keys for things like horse bicycle foot that are almost never used and just take up space.

Also, the default (grayed out "yes") needs to be updated depending on higher access tags: When a way has vehicle=no motor_vehicle=destination the default value of bicycle is still displayed as grayed out "yes", however it should be "no" as bicycle is included in vehicle. As I see it from #2213 only the value of "access" is inherited and not "vehicle".

Yes, I never heard of vehicle until just now.

[slhh]

I think the access field should show a complete list of all present access tags of the feature. This should include any ":conditional", ":lanes", ":forward", or ":backward" key modifiers or their combinations, because we should not display misleading incomplete information.
This list can be a read-only raw tag listing, which is more condensed than the all tags section. Clicking anywhere on the list should unfold the access editing tree as suggested above.

Also, the default (grayed out "yes") needs to be updated depending on higher access tags
Yes, and even higher level conditional settings would change the default. We do not need to evaluate the default in this case, but we can indicate it as "conditional".

In addition country and highway type specific defaults needs to be considered (https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access-Restrictions). In case we don't want to make the behavior country specific, we can display "country default" or "???" instead of a clear (but maybe wrong) "yes" or "no" as the grey default value where required.

for things like horse bicycle foot that are almost never used

I wouldn't call it almost never used, there are 750000 uses of horse, and nearly 4 milllion uses of foot and bicycle each.

I never heard of vehicle until just now.

It's in the wiki since 2008, and there are 152000 uses plus 13000 uses of vehicle:conditional.

[ghost]

It would be nice if at least the vehicle access key would be supported, because the traffic sign 'closed to all vehicles in both directions' seems to be one of the most used restrictive signs (at least in Europe).

I'm unsure if adding another access category to Allowed Access wouldn't make this section too confusing, but maybe iD could support this key in the background, i.e.:

• If there's already a vehicle key, its value could appear next to Motor Vehicles and Bicycles.
• If there's no vehicle key and someone enters the same value to Motor Vehicles and Bicycles, the motor_vehicle=* and bicycle=* tag could be be replaced by a vehicle=* tag.
• If there's already a vehicle key and someone changes either Motor Vehicle or Bicycle access, the vehicle=* tag could be replaced by motor_vehicle=* and bicycle=* keys (with the value of vehicle=* being copied to the key that hasn't been changed).

[matkoniecz]

If there's already a vehicle key, its value could appear next to Motor Vehicles and Bicycles

this would be highly useful, too often people using iD add useless motor_vehicle tags where vehicle tag is set already.

If there's no vehicle key and someone enters the same value to Motor Vehicles and Bicycles, the motor_vehicle=* and bicycle=* tag could be be replaced by a vehicle=* tag.

I am not sure is it the best idea, it seems to be a bit too smart.

If there's already a vehicle key and someone changes either Motor Vehicle or Bicycle access, the vehicle=* tag could be replaced by motor_vehicle=* and bicycle=* keys (with the value of vehicle=* being copied to the key that hasn't been changed).

What about other vehicles?

[ghost]

If there's already a vehicle key and someone changes either Motor Vehicle or Bicycle access, the vehicle=* tag could be replaced by motor_vehicle=* and bicycle=* keys (with the value of vehicle=* being copied to the key that hasn't been changed).
What about other vehicles?

I thought that bicycles are the only non-motor vehicles, but i've just noticed that there are also horse-drawn carriages (carriage=*), so this was a bad idea of mine. Maybe it's still best if a Vehicle entry would be added to Allowed Access.

[haukepribnow]

I've almost submitted a new issue - but now that I've found this discussion, I realize it would have been a duplicate. So therefore I'm posting my prepared issue here as a comment instead:

vehicle=no does not yet entail motor_vehicle=no, bicycle=no, carriage=no

Steps to reproduce
Add vehicle=no to a highway in the iD editor sidebar.

Expected behavior
In the Access section of the iD editor sidebar, the entries for "Motor Vehicles" & "Bicycles" should show "no" in a grey color.

Current behavior
Both entries show "yes" in a grey color.

Background
An advanced access hierarchy making intense use of the vehicle= key was approved in 2009.

The core idea is: vehicle=no should entail motor_vehicle=no, carriage=no, bicycle=no

Despite the wide use of vehicle=no in Germany and despite tools like http://osmtools.de/traffic_signs/ that further propagate the use of vehicle=no, iD does not seem to implement this more advanced access hierarchy yet.

Proposed fix
Implement the simplified hierarchy here: https://wiki.openstreetmap.org/wiki/File:Access_hierarchy_simple2.png (I guess easier said than done.)

[haukepribnow]

Just had a quick look at the code to estimate the effort to tackle at least the vehicle-based hiearchy. The relevant code seems to be here:

iD/modules/ui/fields/access.js

Lines 228 to 246 in a018d27

	if (tags.highway) {
	if (typeof tags.highway === 'string') {
	if (placeholdersByHighway[tags.highway] &&
	placeholdersByHighway[tags.highway][d]) {
	return placeholdersByHighway[tags.highway][d];
	}
	} else {
	var impliedAccesses = tags.highway.filter(Boolean).map(function(highwayVal) {
	return placeholdersByHighway[highwayVal] && placeholdersByHighway[highwayVal][d];
	}).filter(Boolean);
	if (impliedAccesses.length === tags.highway.length &&
	new Set(impliedAccesses).size === 1) {
	// if all the highway values have the same implied access for this type then use that
	return impliedAccesses[0];
	}
	}
	}

[impiaaa]

@1ec5 mentioned this issue to me, and I created a mockup for a more compact access UI, though I was not aware of the existing proposal for a tree view when I made it.