Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please indicate IDs of entities in UI #4211

Closed
ben-strasser opened this issue Aug 2, 2017 · 5 comments
Closed

Please indicate IDs of entities in UI #4211

ben-strasser opened this issue Aug 2, 2017 · 5 comments
Labels
considering Not Actionable - still considering if this is something we want

Comments

@ben-strasser
Copy link

Hi,

I'm using the ID editor in the version that is currently live on openstreetmap.org to fix turn restrictions. A turn restriction should usually have one to and one from role. This is not the case with this restriction:

https://www.openstreetmap.org/relation/2689543

The problem is that the person that created the restriction did not only add the ways directly incident to the via-node. He also added the ways one after and one before. Correcting this should not be a problem. We only need to remove the two superfluous ways and everything is fine. Unfortunately, ID only shows me this:

screenshot from 2017-08-02 15 33 46

As the OSM ways are part of the same road all of them have the same name. It is impossible to figure out from the UI which way is which. Adding the way IDs to the UI would make this clear.

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Aug 3, 2017
@bhousel
Copy link
Member

bhousel commented Aug 3, 2017

In this case it would be easier to just delete the restriction and redo it. You can do this by deleting all the members, then the relation should go away (although this is not obvious).

But there are some things we could improve in iD:

  • make it easy to see which member is which
  • make it easy to do things (like delete) to relations, e.g. support some kind of right click menu for them

@ben-strasser
Copy link
Author

ben-strasser commented Aug 3, 2017 via email

@pnorman
Copy link
Contributor

pnorman commented Aug 3, 2017

There's not any real issue deleting a restriction, although it's not ideal, and shouldn't be necessary.

I'm not sure that showing the object ID is the best way to make it clear what is what. Perhaps highlighting an object on the map when it's moused over in the relation editor would be clearer?

@1ec5
Copy link
Collaborator

1ec5 commented Aug 10, 2017

Perhaps highlighting an object on the map when it's moused over in the relation editor would be clearer?

Yes, I really appreciate that feature in Potlatch 2. (Or was it Potlatch 1?) #3140 basically implements what you’re describing.

As a stopgap, we could also enhance utilDisplayName() to include the names of the to and from ways of the restriction relations.

Edit: Sorry, I was thinking about relation membership list, not the relation member list.

@bhousel
Copy link
Member

bhousel commented Jan 10, 2019

iD has highlighting for relation members now

@bhousel bhousel closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

No branches or pull requests

4 participants