Unable to tab-navigate to All Relations

[1ec5]

Since #4159, hitting Tab does nothing when the last row of All Tags is focused, so it’s impossible to tab-navigate from the All Tags section to the All Relations section.

More broadly, the fix for #4159 surprises me a bit. I thought it’s supposed to be possible to tab-navigate from the webpage content to the address bar, for accessibility reasons.

[bhousel]

Which browser are you using?
Also worth mentioning that we haven't repurposed ⌘L for anything yet, which focuses the location bar in most browsers.

[bhousel]

Actually I think this behavior of Tab creating new tag rows and never leaving the raw tag editor - has been around for a long time, not just since #4159

[1ec5]

Which browser are you using?

• In Firefox 56.0b2 on the Mac, hitting Tab repeatedly causes the focus to get stuck on the value field in the blank row. Only Shift-Tab moves the focus to the key field.
• In Safari 10.1.2 and Chrome 60.0.3112.90, hitting Tab repeatedly causes the focus to alternate between the key and value fields in the blank row.

Neither behavior is consistent with the rest of iD or with how webpages and Web applications typically work in the browser. For example:

• Focus the search bar and hit Tab: the focus moves to the map.
• Focus the map and hit Tab twice: the focus moves to the location bar.

The point of tab navigation is that the user can cycle spatially among the controls in the window, without relying so much on specific hotkeys. I don’t personally rely on tab navigation very much, but it does for instance affect VoiceOver users’ ability to navigate the UI.

[quincylvania]

@1ec5 Thanks for reporting. Turned out to be an easy fix. Let us know if you find other areas where tabbing could be improved 🗂