Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "unit" really part of address in 21 countries #4302

Closed
manfredbrandl opened this issue Aug 30, 2017 · 5 comments
Closed

Is "unit" really part of address in 21 countries #4302

manfredbrandl opened this issue Aug 30, 2017 · 5 comments

Comments

@manfredbrandl
Copy link
Contributor

Currently the "standard" address fields for 21 countries ("ad", "ba", "be", "cz", "dk", "es", "fi", "gr", "hr", "is", "it", "li", "nl", "no", "pl", "pt", "se", "si", "sk", "sm", "va") are "unit", "street", "housenumber" on first line and ["postcode", "city"] on second line. The three german speaking countries Austria, Germany and Switzerland have removed "unit" in PR #4301 . Is unit really appropriate for the remaining 21 countries?

@manfredbrandl manfredbrandl changed the title Is "unit" really part of address in xx countries Is "unit" really part of address in 21 countries Aug 30, 2017
@jjiglesiasg
Copy link

I will loved to have State instead of unit as part of the address

@JamesKingdom
Copy link
Collaborator

JamesKingdom commented Aug 30, 2017

I will loved to have State instead of unit as part of the address

But this would still be incorrect, here's addr:state.

@slhh
Copy link
Contributor

slhh commented Aug 31, 2017

@JamesKingdom
The taginfo map doesn't really indicate where addr:steet is useful. E.g. it looks like it were useful in the German speaking countries according to the map, but it isn't. These countries do have states, but the state is not part of an address there. A very small fraction of addresses are tagged with addr:state by mistake, because the state exists. Due to the huge amount of tagged addresses in these countries, the small fraction of errors is sufficient to make the taginfo map red.

@jjiglesiasg
Copy link

jjiglesiasg commented Aug 31, 2017 via email

@bhousel
Copy link
Member

bhousel commented Sep 7, 2017

If you want the address field changed, please submit a PR. I don't have the bandwidth to track down how it should look in all the different parts of the world.

This Wikipedia page lists them, and it looks like at least several European countries do have some notion of sub-building addressing (floor, apartment, unit, etc):
https://en.wikipedia.org/wiki/Address_(geography)#Format_by_country

@bhousel bhousel closed this as completed Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants