Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback area preset loses its area=yes tag #4424

Closed
bhousel opened this issue Oct 10, 2017 · 3 comments
Closed

Fallback area preset loses its area=yes tag #4424

bhousel opened this issue Oct 10, 2017 · 3 comments
Labels
bug A bug - let's fix this! bug-release-blocker An important bug - let's get this fixed in the next release!

Comments

@bhousel
Copy link
Member

bhousel commented Oct 10, 2017

Seems like the area=yes tag is getting removed from the fallback "Area" preset - this turns it back into a normal line. Not sure when this regressed, but we should fix it.

areayes

@bhousel bhousel added bug A bug - let's fix this! bug-release-blocker An important bug - let's get this fixed in the next release! labels Oct 10, 2017
@willemarcel
Copy link
Contributor

@bhousel why does this preset is available to an area feature? I think it should be available to lines, as sometimes we need to apply area=yes tag to a feature that was drawn as line.

@bhousel
Copy link
Member Author

bhousel commented Oct 10, 2017

@bhousel why does this preset is available to an area feature? I think it should be available to lines, as sometimes we need to apply area=yes tag to a feature that was drawn as line.

Yes, we should have a way to switch between area <-> line.

I tried adding it here, but decided not to merge until we can limit it to closed features: #1828 (comment)

@bhousel
Copy link
Member Author

bhousel commented Oct 11, 2017

This broke in 9882cf1, fixing #4114.

It looks like the new code is correct (removing area=yes and adding it back only if needed per areaKeys lookup) - in all cases except for the case where the preset is trying to set the area tag to something. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! bug-release-blocker An important bug - let's get this fixed in the next release!
Projects
None yet
Development

No branches or pull requests

2 participants