Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash message if user is trying to edit a shape that is connected to a hidden feature #4493

Closed
hikemaniac opened this issue Oct 31, 2017 · 5 comments
Labels
considering Not Actionable - still considering if this is something we want usability An issue with ease-of-use or design

Comments

@hikemaniac
Copy link
Contributor

When I was trying to draw an area, suddenly iD didn't allow me to add new nodes to the area.

adding node impossible

Changing the zoom level or deconnecting (or even deleting) some nodes doesn't help either. The workaround is to create a new node and drag it onto the area outline in order to add a new vertex to the area.

I'm using Mac OSX Yosemite 10.10.5 and Firefox 56.0.2.

@bhousel
Copy link
Member

bhousel commented Oct 31, 2017

That seems like it should work, can you share the osm id of the object?
You can open the measurement panel with ⌘ Cmd+⇧ Shift+M, and on there it will display the id (some long number starting with 'w').

@bhousel bhousel added the waitfor-info Waiting for more info label Oct 31, 2017
@hikemaniac
Copy link
Contributor Author

There are two problems. The first one is that I couldn't finish drawing the area because of this bug and so I didn't upload it to the OSM server. The second problem is that even if I would upload it I don't believe it would help, because refreshing the tab will allow me to add nodes again (after restoring the changes).

I have absolutely no idea what causes this bug but it might have something to do with the fact that I connected the area to other areas at several points. However it is not the first time I experience this. Please let me know if there are more things I can tell you to help fix it.

@bhousel
Copy link
Member

bhousel commented Nov 1, 2017

Thanks @hikemaniac .. It looks like you might have connected your new area to an existing area that also serves as a boundary, and the boundary is hidden.

Can you try this:

  • Open the "Map Data" panel (or press F)
  • Expand "Map Features" and make sure "Boundaries" is checked (so they become visible)
  • See if you can now change the shape?

screenshot 2017-11-01 14 34 42

@hikemaniac
Copy link
Contributor Author

Thanks a lot, this really was the cause of the problem (ironically it was actually the section paths which I had disabled for less confusion when mapping the area). Maybe we could add some kind of warning when trying to join a node with a hidden object?

@bhousel
Copy link
Member

bhousel commented Nov 1, 2017

Thanks a lot, this really was the cause of the problem (ironically it was actually the section paths which I had disabled for less confusion when mapping the area). Maybe we could add some kind of warning when trying to join a node with a hidden object?

Good to know that was the issue! I think we can probably find a way to flash a message to the user that the thing they are trying to do is blocked. If you try to use the right click menu to edit this shape, you'll see that all the operations are disabled and the reason - but that doesn't help someone who is just trying to move nodes around.

@bhousel bhousel added usability An issue with ease-of-use or design and removed waitfor-info Waiting for more info labels Nov 1, 2017
@bhousel bhousel changed the title Unable to add a node to an area Flash message if user is trying to edit a shape that is connected to a hidden feature Nov 1, 2017
@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Nov 1, 2017
@bhousel bhousel closed this as completed in c6ab9e5 Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants