Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersection check complicates fixing intersection issues #4771

Open
slhh opened this issue Feb 4, 2018 · 1 comment
Open

Intersection check complicates fixing intersection issues #4771

slhh opened this issue Feb 4, 2018 · 1 comment
Assignees
Labels
bug A bug - let's fix this!

Comments

@slhh
Copy link
Contributor

slhh commented Feb 4, 2018

Dragging a node should not be prevented when an intersection issue of the moved edges does already exist. Fixing the issues in the screenshot should not need to override the intersection protection.

grafik

@bhousel I have found the issue in the code, and constructed the example afterwards. I can try to make a pull request. Maybe, I can also address some related issues (#4769, #4745).

Btw, I can also offer a faster implementation of the geoHasSelfIntersections function. I've made some experiments, and got a reduction of execution time to approximately 40% in case of long lines.
Unfortunately, it doesn't solve #4731, there seems to be another bottleneck.

@bhousel
Copy link
Member

bhousel commented Feb 4, 2018

Yes @slhh that sounds great - I'd definitely welcome a pull request for these 👍

@bhousel bhousel added the bug A bug - let's fix this! label Feb 4, 2018
@bhousel bhousel self-assigned this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants