Self intersection check is still too aggressive

[hikemaniac]

Recently I stumbled upon some cases where the self intersection check complicates mapping.

I actually just wanted to continue mapping this field and connect its new nodes to the scrub area but iD wouldn't let me.

[manfredbrandl]

May I propose a different strategy to avoid self intersecting lines and areas? iD could check modified objects after the user unselected them. If there are Warnings or Errors detected a new field right to the Save Button could appear and show that the next Save will have Warning/Errors and maybe how many in colour and/or number. Clicking on this field could switch to the list of warnings presented after Save is clicked. The change of cursor could appear while editing to warn burn other to block.

[bhousel]

If there are Warnings or Errors detected a new field right to the Save Button could appear and show that the next Save will have Warning/Errors and maybe how many in

I'm ok with this, especially combined with small on map warning icon like described here ?
#4776 (comment)

I really think I could use that UI pattern to just solve a lot of the most common "iD makes it too easy to / iD makes it too hard to" issues that keep coming up.

[bhousel]

@hikemaniac you probably already know this already but - in the mean time until decide on the appropriate fix, you can just move your node here, and then move the other nodes wherever you want to.

Yes avoiding self intersections is an extra step, but I don't think the current checks really prevent you from doing what you are trying to do...

[hikemaniac]

You probably already know this already but - in the mean time until decide on the appropriate fix, you can just move your node here, and then move the other nodes wherever you want to.

Yep, I already did this and successfully uploaded my changeset 😊 but I think that the self-intersection checks complicate mapping in such cases.
By the way (as already reported in #4731) the performance when drawing large areas and lines becomes really bad at some point and this even crashed my browser once. So I believe that @manfredbrandl's idea would really help a lot.

[manfredbrandl]

I'm ok with this, especially combined with small on map warning icon like described here ?
#4776 (comment)

I appreciate warning icons on the map, they point you to the exact position of the problem and adds another usefull feature with and without the new field right to the Save button.

[bhousel]

One idea: we put them at the top next to save, and also on screen

Another idea (I like this better)
Add a panel on the side, maybe w/badge showing the number of warnings.. Users can click on the list to see and take them to the thing to fix. The panel gives us more opportunity to show/hide certain things (let user control what they want to see). Badges are now an accepted UI pattern.

[slhh]

I actually just wanted to continue mapping this field and connect its new nodes to the scrub area but iD wouldn't let me.

You can override the intersection check by holding the Alt key down. Its fair to require this because a new error is at least temporarily introduced. Maybe, we can show a hint to use the Alt modifier, e.g. where the shortcut errors are displayed, when placing of the node is disabled due to an intersection.

In addition dragging of a node doesn't seem to be the right tool for the usecase. We should have a partial redraw tool for a part of a way.
Idea for the UI:
Drag the midpoint at an edge to indicate that this edge should be reshaped, and drag it on one of the nodes of the edge to start redrawing from that node. This should put the user in the drawWay mode with the other node of the original edge being the target. Further nodes of the way in the same direction can serve as alternate targets to finish, which would remove the skipped nodes of the original way.

@bhousel I like the on map warning concept in general, but we should not overuse it.

[manfredbrandl]

Another idea (I like this better)

That's really better. @bhousel do you plan to have the same UI for resolving warnings from the panel on the side and from the Save button? I think that would make the UI simpler.

[bhousel]

That's really better. @bhousel do you plan to have the same UI for resolving warnings from the panel on the side and from the Save button? I think that would make the UI simpler.

Yeah, I hadn't actually thought it through very much, and I just threw those screenshots together pretty quickly. I don't know what I'm doing 😄 I initially thought a button at the top, then the idea changed to another pane on the side, which opens up a lot more options to explain / navigate to / filter the warnings.

[bhousel]

Something like the issue manager is coming soon in #5830 so I'm going to close here, and we can open a separate issue for validating self-crossing lines.