Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of new master (2.9.0) is missing UI icons in the right tool bar. #5077

Closed
LorenMueller opened this issue Jun 14, 2018 · 4 comments
Closed
Labels
bug A bug - let's fix this!

Comments

@LorenMueller
Copy link
Contributor

No description provided.

@bhousel
Copy link
Member

bhousel commented Jun 14, 2018

Make sure you npm install and then npm run all and you should get them!
The way we build the icons has changed a bit.

@bhousel bhousel added the bug A bug - let's fix this! label Jun 29, 2018
@bhousel
Copy link
Member

bhousel commented Jun 29, 2018

I'm digging into this today and I can confirm that on windows, the iD-sprite.svg is built but empty.

It's almost certainly because of this wildcard glob 'svg/iD-sprite/**/*.svg' on this line:

"dist:svg:id": "svg-sprite --symbol --symbol-dest . --shape-id-generator \"iD-%s\" --symbol-sprite dist/img/iD-sprite.svg 'svg/iD-sprite/**/*.svg'",

I'll look for a workaround for telling svg-sprite how to find the source .svg files.

@bhousel
Copy link
Member

bhousel commented Jun 29, 2018

Hey @LorenMueller I just pushed a change that fixes this. Wrapping the wildcard glob in double quotes instead of single quotes was needed 😅

@LorenMueller
Copy link
Contributor Author

I confirmed that the update works. Nice work @bhousel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants