Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site_type to Archaeological Site preset #5124

Closed
shiftee opened this issue Jul 6, 2018 · 5 comments
Closed

Add site_type to Archaeological Site preset #5124

shiftee opened this issue Jul 6, 2018 · 5 comments
Assignees
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@shiftee
Copy link

shiftee commented Jul 6, 2018

In Ireland there are many ringforts scattered across the country.
Finding these is trivial using the Old British/Irish maps and the aerial imagery so sometimes I randomly wander around adding them.
The process is a bit tedious as I need to set the site_type and fortification_type keys and values manually.

Can a preset for this be added?

Tags:
historic=archaeological_site
site_type=fortification
fortification_type=ringfort
name=*

OSM Wiki Page for Ringforts

Thanks,
Mark

@bhousel
Copy link
Member

bhousel commented Jul 9, 2018

I don't think it makes sense to add a preset for something as specific as fortification_type=ringfort, which has only a very local focus..

But we could add some more fields to the "Archaeological Site" preset to make it easier to map kinds of sites, or maybe add a "Historic Fortification" which has the site_type=fortification already filled in (if this is a common thing).

Right not the preset doesn't have very many fields:
screenshot 2018-07-08 22 14 11

Also, worth mentioning that if you are mapping a lot of these things with very specific tags set, you can Ctrl+C / Ctrl+V to copy and paste them with the tags set up the way you like.

@bhousel bhousel added preset An issue with an OpenStreetMap preset or tag considering Not Actionable - still considering if this is something we want labels Jul 9, 2018
@shiftee
Copy link
Author

shiftee commented Jul 9, 2018

Perfect, I didn't know you could copy & paste the nodes.
This solves the need to setup each node (boring, repetitive and error prone).

For me adding a site_type field to "Archaeological Site" would be an improvement.
A "Historic Fortification" preset can probably wait until there is more user interest.

Regardless, my primary issue is resolved, shall I close?

@bhousel
Copy link
Member

bhousel commented Jul 9, 2018

For me adding a site_type field to "Archaeological Site" would be an improvement.
Regardless, my primary issue is resolved, shall I close?

I'll close this after I improve the Archaeological Site preset

@bhousel bhousel removed the considering Not Actionable - still considering if this is something we want label Jul 9, 2018
@bhousel bhousel changed the title Preset for Ringforts Add site_type to Archaeological Site preset Jul 9, 2018
@JamesKingdom
Copy link
Collaborator

I added site_type, with a combo box.

@bhousel
Copy link
Member

bhousel commented Jul 9, 2018

Thanks @JamesKingdom !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants