Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel when drawing tulip road in walkthrough causes freeze #5295

Closed
shbgr opened this issue Sep 5, 2018 · 1 comment
Closed

Cancel when drawing tulip road in walkthrough causes freeze #5295

shbgr opened this issue Sep 5, 2018 · 1 comment
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!

Comments

@shbgr
Copy link

shbgr commented Sep 5, 2018

If you cancel the drawing operation of tulip road (in walkthrough) the browser freezes completely (at least in Chrome).
Seems like drawWay.cancel() gets stuck in an infinite loop here:

while (context.graph() !== startGraph) {
   context.pop();
}

How to reproduce

  • start walkthrough
  • select "lines"
  • start drawing tulip road
  • cancel with ESC or by clicking the first node again
  • browser freezes
@bhousel bhousel added the bug-release-blocker An important bug - let's get this fixed in the next release! label Sep 5, 2018
@bhousel
Copy link
Member

bhousel commented Sep 5, 2018

Thanks for reporting @shbgr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!
Projects
None yet
Development

No branches or pull requests

2 participants