Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikidata field should autocomplete labels #5544

Closed
1ec5 opened this issue Dec 2, 2018 · 5 comments
Closed

Wikidata field should autocomplete labels #5544

1ec5 opened this issue Dec 2, 2018 · 5 comments
Assignees
Labels
field An issue with a field in the user interface validation An issue with the validation or Q/A code
Milestone

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Dec 2, 2018

#5500 implemented a Wikidata field that contains a plain text Identifier box for the QID of a Wikidata item. As a Wikidata contributor, I would find this field to be much more intuitive if it behaves like the claim text boxes on Wikidata. I think it would also be more intuitive to mappers who are unfamiliar with Wikidata and wouldn’t know how to come up with a QID on their own (since the Wikipedia field doesn’t automatically appear when you show the Wikidata field).

On Wikidata, you can type in a label and autocompletion suggestions appear, similar to the Wikipedia field’s title box:

label

But you can also paste in a QID and a matching item appears:

qid

Either way, once you select the suggestion, the label ends up in the text box:

result

Even though Wikidata is built atop QIDs, the QIDs are treated like a machine-readable implementation detail and deemphasized as much as possible in UI.

So I’d suggest rearranging the Identifier, Label, and Description boxes, so that once you select an item, the Label box at the top contains the label, the read-only Description box follows, and the read-only Identifier box contains the QID at the bottom.

@nicolasmaia
Copy link

This would be particularly good when used for the Architect, Species/Animal, Operator, Network, Brand, Artist, Name Etymology and Subject fields.

So when typing out, for example, in an architect field "Santiago Calatrava", a Wikidata dropdown menu would appear, and upon selection we'd automatically set architect=Santiago Calatrava and wikidata:architect=Q168482.

@bhousel
Copy link
Member

bhousel commented Dec 16, 2018

So when typing out, for example, in an architect field "Santiago Calatrava", a Wikidata dropdown menu would appear, and upon selection we'd automatically set architect=Santiago Calatrava and wikidata:architect=Q168482.

I think people are generally in favor of the idea except for the "automatically" part 👍

@nicolasmaia
Copy link

nicolasmaia commented Dec 16, 2018

@bhousel if we know that the fields architect and wikidata:architect are exact equivalents, what's the risk?

@1ec5
Copy link
Collaborator Author

1ec5 commented Dec 24, 2018

Here’s an example Wikidata API query that would be kicked off after typing in “Junction City” when iD is set to the Vietnamese locale. Notice how the labels and descriptions are in English as a fallback.

Note that this issue is specifically about the behavior of the existing wikidata field type, which is currently only used for the Wikidata field (corresponding to the wikidata tag). #5484 is about adopting that field type for the Operator field (operator:wikidata). I do think this issue would need to be addressed before Wikidata functionality could be added to any other fields, because there isn’t a straightforward mapping from taginfo autocompletion results to Wikidata QIDs.

@quincylvania quincylvania self-assigned this Mar 28, 2019
@quincylvania quincylvania added validation An issue with the validation or Q/A code field An issue with a field in the user interface labels Mar 28, 2019
@quincylvania quincylvania added this to the 2.15.0 milestone Mar 28, 2019
@quincylvania
Copy link
Collaborator

I did this.

wikidata demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

4 participants