Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straighten multiple ways in one operation #5740

Closed

Conversation

jguthrie100
Copy link
Contributor

Implements aspects of #2058 (multiple way straightening)

This change allows the user to select a number of joined ways and straighten them all in one operation.

  • I've written a number of additional tests to cover some of the new scenarios

straighten

@jguthrie100
Copy link
Contributor Author

One thing to consider - should joined ways that go in opposite directions be able to be straightened together.
My changes only allow ways that go in the same direction to be straightened, but I could change it to allow for direction to not be an issue..

@bhousel
Copy link
Member

bhousel commented Jan 21, 2019

Implements aspects of #2058 (multiple way straightening)

Nice, I'll have to check this a bit more thoroughly later this week 👍

One thing to consider - should joined ways that go in opposite directions be able to be straightened together.
My changes only allow ways that go in the same direction to be straightened, but I could change it to allow for direction to not be an issue..

Sure - I don't think the direction matters.

 - operationStraighten now allows for two vertices to be selected and straightened between
 - Added test cases
 - Split selectedIDs between nodes and ways
 - Slice the length of nodes to be straighten to between the 2 selected nodes
@jguthrie100
Copy link
Contributor Author

I've added the ability to straighten between 2 vertices too. Just select all the ways between (and including) the 2 vertices and it should allow the user to straighten between them

straighten-vertices

@jguthrie100
Copy link
Contributor Author

jguthrie100 commented Feb 24, 2019

Fixed it so that connected ways going in different directions can be straightened

straighten-multiple-directions

@bhousel
Copy link
Member

bhousel commented Mar 22, 2019

Thanks @jguthrie100 , I just merged this..
(It doesn't show as merged on GitHub because I rebased it to avoid conflicts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants