Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low performance of changeset comment field #6249

Closed
tordans opened this issue Apr 28, 2019 · 3 comments
Closed

Low performance of changeset comment field #6249

tordans opened this issue Apr 28, 2019 · 3 comments
Labels
performance Optimizing for speed and efficiency
Milestone

Comments

@tordans
Copy link
Collaborator

tordans commented Apr 28, 2019

For the changeset comment field, I still have the issue from #6054

Its really bad when I type my commit message. I type and nothing happens and then the text appears all at once.

I took some of those Google Chrome performance screenshots. But I don't really know how to read them, so I don't know what parts are useful.

Do I read it right, that every key press triggers some big re-rendering action?

Bildschirmfoto 2019-04-28 um 06 39 16

Bildschirmfoto 2019-04-28 um 06 39 30

Bildschirmfoto 2019-04-28 um 06 40 14

@bhousel
Copy link
Member

bhousel commented Apr 28, 2019

Yes thanks for ticketing - I know about this and tried addressing it in ae06e28
But realized then that it didn't completely fix the issue.

This is why I'm pushing on the d3 upgrade this week in #6245 - to eliminate that as one potential source that might trigger the style recalculation.

@bhousel bhousel added the performance Optimizing for speed and efficiency label Apr 28, 2019
@bhousel
Copy link
Member

bhousel commented Apr 28, 2019

Also worth mentioning - if you are using the profiler, you should uncheck the "screenshots" feature, because that will slow things down even more and possibly mask the actual source of the slowness you're investigating.

@tordans
Copy link
Collaborator Author

tordans commented May 1, 2019

I can confirm, the changeset comments field feels snappy again.

For comparison:
(From "click on save-button to click on commit-button")

Bildschirmfoto 2019-05-01 um 07 22 22

Bildschirmfoto 2019-05-01 um 07 23 31

Bildschirmfoto 2019-05-01 um 07 24 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Optimizing for speed and efficiency
Projects
None yet
Development

No branches or pull requests

2 participants