Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building crosses highway validation rule should check layer=* #6364

Closed
Nakaner opened this issue May 15, 2019 · 5 comments
Closed

Building crosses highway validation rule should check layer=* #6364

Nakaner opened this issue May 15, 2019 · 5 comments

Comments

@Nakaner
Copy link

Nakaner commented May 15, 2019

The intersection of a highway=footway with a building=roof + layer=1 is flagged by the validator. The validator suggests to use a bridge or tunnel.

buildingsense

That' wrong. If it were a normal building, not a roof, tunnel=building_passage were correct in some circumstances except indoor mapping (you don't want to have tunnel=yes added to any indoor footway).

The simplest and IMHO most sensible approach is to check if both objects are on the same layer=* (defaults to 0 in OSM). In the example given above, the roof has layer=1 and therefore there is no reason to complain.

@BjornRasmussen
Copy link
Contributor

I agree with you about this, but @quincylvania has set up the validation such that adding covered=yes to the highway underneath will satisfy the validator. This same issue keeps coming up from mappers unaware of this behavior, so clearly we need to add a covered option to the list of fixes to prevent the mistagging of a large number of features. I consider either understanding the layer tag or letting people know about using covered a big priority for v2.15.0 if we don't want people to be opening new issues and mistagging features all summer long.

@quincylvania
Copy link
Collaborator

I agree we need to make this easier soon. I almost always skip mapping or fixing these instances myself because it takes too many clicks.

@bhousel
Copy link
Member

bhousel commented May 15, 2019

I agree we need to make this easier soon. I almost always skip mapping or fixing these instances myself because it takes too many clicks.

Strong agree - @quincylvania can you just add a fix like "Tag the highway as covered" and close all the open issues related to this? 👍

@bhousel
Copy link
Member

bhousel commented May 15, 2019

This is a dup of #5924 where we already decided that we're not going to expect data consumers to know what levels building footprints exist at or guess at the default building levels that certain building types tend to exist at.

@bhousel bhousel closed this as completed May 15, 2019
@BjornRasmussen
Copy link
Contributor

This is a dup of #5924 where we already decided that we're not going to expect data consumers to know what levels building footprints exist at or guess at the default building levels that certain building types tend to exist at.

Yes, but this asks for layer, not level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants