Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-step Extract operation #6674

Closed
slhh opened this issue Jul 23, 2019 · 2 comments
Closed

Single-step Extract operation #6674

slhh opened this issue Jul 23, 2019 · 2 comments
Assignees
Labels
operation An editing operation / edit menu item
Milestone

Comments

@slhh
Copy link
Contributor

slhh commented Jul 23, 2019

There are some issues with the extract operation in the current preview:

  • the POI to be placed does not always follow the mouse pointer directly, but often with a random offset.
  • the POI to be placed is invisible while the mouse is over the toolbar. The user might assume the operation is already complete.
  • when pressing ESC before placing the POI this results in 2 changes to be saved but no undo available.
  • the favorites should not be shown before the operation is complete.
  • the safe button should better be replaced with cancel (like the drawing mode) until the POI is placed.
@quincylvania
Copy link
Collaborator

I've noticed some of these issues and I think my preferred solution would be to instantly place the point in the middle of the feature (or as close as possible in-frame). The user can then move the point as needed. This seems simpler than building out a workflow, plus it's easier on touchscreens.

@quincylvania quincylvania added the operation An editing operation / edit menu item label Jul 24, 2019
@quincylvania quincylvania added this to the 3.0.0 milestone Jan 9, 2020
@quincylvania quincylvania self-assigned this May 13, 2020
@quincylvania quincylvania modified the milestones: v3 prototype, 2.18.0 May 13, 2020
@quincylvania
Copy link
Collaborator

my preferred solution would be to instantly place the point in the middle of the feature

I made it work like this. It's definitely simpler, consistent with the related Combine and Downgrade operations, and touchscreen friendly. Plus it automatically puts points in the center of areas, so mappers won't have to worry about placing points perfectly and can oftentimes skip moving them altogether.

I also realized that the "Extract this point" validation fix for point-as-vertex warnings already works likes this, so there's precedent within iD. It's good making them consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operation An editing operation / edit menu item
Projects
None yet
Development

No branches or pull requests

2 participants