Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR Languages #6702

Merged
merged 5 commits into from Aug 2, 2019
Merged

CLDR Languages #6702

merged 5 commits into from Aug 2, 2019

Conversation

quincylvania
Copy link
Collaborator

@quincylvania quincylvania commented Jul 31, 2019 •
edited

Closes #2457 and #4990.

This gives iD much more knowledge about languages using the cldr-localenames-full module.

  • We're no longer limited to the wikipedia language list
  • Language names can be translated as needed without going through Transifex
  • Only translations for iD's supported languages are checked in

Screen Shot 2019-07-31 at 1 42 54 PM

Screen Shot 2019-07-31 at 1 41 41 PM

  • Future work: nicer names for languages in a certain script when CLDR doesn't provide a name. Luckily CLDR does provide translated script names. For example, sr-Latn is currently displayed as "Serbian (sr-Latn)" in English when it should be "Serbian (Latin)".

@quincylvania
Use CLDR for a translated language list in the localized name field i…
e37948f 
…nstead of untranslated wmf site matrix (close #2457)

Translate language names in the community index list (close #4990)
@quincylvania quincylvania changed the base branch from master to 2.15 August 1, 2019 16:52
@bhousel
Copy link
Member

bhousel commented Aug 2, 2019 •
edited

This looks pretty good to me! Feel free to merge 👍
(test failures look unrelated to this - we should figure out what's going on with eslint)

@quincylvania quincylvania merged commit 20e33a7 into 2.15 Aug 2, 2019
@quincylvania quincylvania deleted the cldr-languages branch August 2, 2019 16:59
@1ec5 1ec5 mentioned this pull request Aug 3, 2019
Closed
@quincylvania quincylvania added this to the 2.15.5 milestone Aug 23, 2019
@bhousel bhousel mentioned this pull request Aug 26, 2019
Merged
@1ec5 1ec5 mentioned this pull request Oct 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel Awaiting requested review from bhousel

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quincylvania @bhousel