Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panning on selection is #7820

Closed
polychloriert opened this issue Jul 21, 2020 · 6 comments
Closed

Panning on selection is #7820

polychloriert opened this issue Jul 21, 2020 · 6 comments
Assignees
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!
Milestone

Comments

@polychloriert
Copy link

It seems to me that an auto-centering feature was added that engages when an object is selected. The map will pan to the center of the object, irrespective of where I selected the object. This makes editing large objects, such as long paths, very cumbersome and annoying as the editor will pan away from the part of the object that I wanted to edit. Thanks.

@VictorIE-OSM
Copy link

I have also noticed this. Sometimes the object is even off screen, e.g. a length of road that goes around a hill, and the map centres at the focal point of the arc, with no arc visible.

@quincylvania
Copy link
Collaborator

Welcome, @polychloriert. iD shouldn't be moving the map just because you click on something. Do you have steps to reproduce this behavior? Or a screencapture?

@quincylvania quincylvania added the waitfor-info Waiting for more info label Jul 21, 2020
@polychloriert
Copy link
Author

Thanks for the quick reply. I just checked again and the described behavior is no longer present. Weird. Thanks anyway :)

@polychloriert
Copy link
Author

polychloriert commented Jul 22, 2020

Ah, got it again. If I had to speculate, it's probably some kind of state bug during editing.
How to reproduce it:

  1. Edit a feature that is considerably larger than the current map pane
  2. Let the editor pan the map at least once to focus on the next/current node (happens during repeated node deletion for example)
  3. Now, when seleting another feature, the editor will always pan to the feature's center of mass
    The behavior can be fixed temporarily by reloading the page. Only until the above steps are repeated, of course.

@quincylvania
Copy link
Collaborator

@polychloriert Weird!! Definitely a bug. Thanks for reporting and for the detailed steps.

@quincylvania quincylvania added bug-release-blocker An important bug - let's get this fixed in the next release! and removed waitfor-info Waiting for more info labels Jul 22, 2020
@quincylvania quincylvania added this to the 2.18.3 milestone Jul 22, 2020
@quincylvania quincylvania self-assigned this Jul 22, 2020
@polychloriert
Copy link
Author

No, thank YOU for working on iD - it keeps getting better and better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-release-blocker An important bug - let's get this fixed in the next release!
Projects
None yet
Development

No branches or pull requests

3 participants