Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a direction using the up/down arrow values go negative. #8206

Open
sekerob opened this issue Nov 17, 2020 · 3 comments
Open

When adding a direction using the up/down arrow values go negative. #8206

sekerob opened this issue Nov 17, 2020 · 3 comments
Labels
considering Not Actionable - still considering if this is something we want field An issue with a field in the user interface

Comments

@sekerob
Copy link

sekerob commented Nov 17, 2020

Had this a number of times being flagged on the issue report, which is dating from before the 5 degrees step change i.e. when direction incremented/decremented by 10 degrees. The simplest reproducible test is to enter direction=0, then using the down, the value goes -5. The OSMI issue report flags this as a suspect value. Going from 355 to 5 and back effectively turns 355 to -5 too.

O/T WishListed: Fantastic would be if 1) holding the up/down in/decrementing rolls on rather that clicking multiple times to get to a desired beam alignment. 2) Outstanding would be if one could grab the beam and drag it around.

thanks for reading.

@quincylvania
Copy link
Collaborator

Welcome, @sekerob. Is this causing problems for any actual data consumers? 355° and -5° are equivalent for the direction a stationary object is facing.

Outstanding would be if one could grab the beam and drag it around.

I'd consider this a separate issue…

@quincylvania quincylvania added considering Not Actionable - still considering if this is something we want field An issue with a field in the user interface labels Dec 2, 2020
@sekerob
Copy link
Author

sekerob commented Dec 4, 2020

Thanks for your comment and probably no, a data consumer will likely know that all numbers are an offset to 0, due north. Unfortunately hitting false-positive or ignore does not resolve... few weeks later the same issue pops up again. Anyway, thought if greater than 360, subtract 360 and if less than zero, add 360 would cure the issue. Hardly expect an editor doing a full circle twice.
cheers

@Jeinzi
Copy link

Jeinzi commented Jun 15, 2022

Happened to me too. By using the up and down arrows I accidentally added negative orientations and Osmose flagged every node as suspicious.

355° and -5° are equivalent for the direction a stationary object is facing

That's certainly true, but using additional characters for more digits (i.e. 1075°) or negative numbers will mildly bloat the database. The wiki also states that numerical orientations should be in the range [0, 359].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want field An issue with a field in the user interface
Projects
None yet
Development

No branches or pull requests

3 participants