Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select [selectChild] - differentiate parent/child selection #8577

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Select [selectChild] - differentiate parent/child selection #8577

merged 3 commits into from
Jul 14, 2021

Conversation

mbrzakovic
Copy link
Collaborator

Resolves: #8298

@mbrzakovic
select - differentiate parent/child selection
c8f162b 
introduce more accessible shortcuts
@mbrzakovic mbrzakovic requested a review from 1ec5 July 13, 2021 17:53
@mbrzakovic mbrzakovic added the accessibility Relates to personal ability or assistive tools label Jul 13, 2021
@mbrzakovic mbrzakovic added this to the 2.20.0 milestone Jul 13, 2021
@mbrzakovic mbrzakovic changed the title Select [selectParent] - differentiate parent/child selection Select [selectChild] - differentiate parent/child selection Jul 14, 2021
@mbrzakovic
Copy link
Collaborator Author

This change can be more precise.

  1. selectChild is currently like 'undo-selection' from selectParent. I think its better if selectChild could be used stand-alone as well if 'undo-selection' is not possible. e.g.: (browsing-> selectWay -> selectChild).
  2. In keyboard shortcuts ui menu, selectChild does not belong to 'With node selected' section. It should belong to new: "With node selected' section.
    The next commit is addressing this.

@mbrzakovic
selectChild as standalone.
416799c 
Keyboard shortcuts new section - way selected
Moved 'help' section to left in keyboard section
@mbrzakovic
Copy link
Collaborator Author

Keyboard shortcuts ui menu now. (change: 'help' section to bottom left, new 'with way selected' section on bottom right)
image

@1ec5 1ec5 mentioned this pull request Jul 14, 2021
Open
1ec5
1ec5 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@1ec5 1ec5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting apart this operation and making it easier to reach on the keyboard. 😃 This same set of shortcuts will be convenient for an eventual implementation of navigating between relations and their member ways via keyboard: #3604. I just have a question about an edge case that could reasonably be resolved either way.

modules/modes/select.js Show resolved Hide resolved
data/core.yaml Outdated Show resolved Hide resolved
@1ec5 1ec5 mentioned this pull request Jul 14, 2021
Open
@mbrzakovic mbrzakovic merged commit ca8e4df into develop Jul 14, 2021
@mbrzakovic mbrzakovic mentioned this pull request Jul 26, 2021
Merged
@bhousel bhousel mentioned this pull request Aug 6, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees
No one assigned
Labels
accessibility Relates to personal ability or assistive tools
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

Internationalize the key binding for selecting a parent way
2 participants
@mbrzakovic @1ec5