Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update documentation and remove phantomjs references #8843

Closed
2 tasks done
tyrasd opened this issue Dec 7, 2021 · 0 comments
Closed
2 tasks done

update documentation and remove phantomjs references #8843

tyrasd opened this issue Dec 7, 2021 · 0 comments
Labels
chore-build Improvements to the iD build scripts / CI environment documentation Improvements to the iD documentation
Milestone
2.21.0

Comments

@tyrasd
Copy link
Member

tyrasd commented Dec 7, 2021 •
edited

see #8764 (comment):

  • remove code referencing phantomjs
  • update the documentation for running tests (e.g. requirement of installing chrome / setting CHROME_BIN env, etc.)
@tyrasd tyrasd added documentation Improvements to the iD documentation chore-build Improvements to the iD build scripts / CI environment labels Dec 7, 2021
@tyrasd tyrasd mentioned this issue Dec 7, 2021
Merged
@tyrasd tyrasd added this to the 2.21.0 milestone Dec 7, 2021
@tyrasd tyrasd closed this as completed in 524cd5d Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore-build Improvements to the iD build scripts / CI environment documentation Improvements to the iD documentation
Projects
None yet
Milestone
2.21.0
Development

No branches or pull requests
1 participant
@tyrasd