Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikidata tag prevents editing empty name or operator field #8892

Open
boothym opened this issue Jan 10, 2022 · 4 comments
Open

Wikidata tag prevents editing empty name or operator field #8892

boothym opened this issue Jan 10, 2022 · 4 comments

Comments

@boothym
Copy link
Contributor

boothym commented Jan 10, 2022

I understand why having a wikidata tag disallows editing of the name or operator field, as you don't want people to mistakenly change the name or operator.

However, if you come across a named object with a wikidata tag and you want to add an operator (and vice-versa with the name field if it already has an operator) - the field is locked despite being empty. This should be fixed so that all empty field are editable, without having to go down to the all tags section.

@pnorman
Copy link
Contributor

pnorman commented Jan 10, 2022

This would result in if someone inputs an operator/name, they can't change it.

@boothym
Copy link
Contributor Author

boothym commented Jan 10, 2022

Suppose it would, but then the same happens if you add a wikidata tag to a named object and you then try and change the name.

Wonder if iD is able to keep the fact that the name/operator tag was empty to begin with, in its memory, so it doesn't lock the field for the duration of your session?

@tordans
Copy link
Collaborator

tordans commented Jan 10, 2022

I wonder: Those examples you have in mind, should they maybe be added to NSI. That would solve the described issue of having no operator by adding it in the first place or suggesting to add it in the UI.

@boothym
Copy link
Contributor Author

boothym commented Jan 10, 2022

The example I came across today wasn't a brand or something that could be added to NSI though (otherwise I would).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants