Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagging schema: always load strings to matching presets version #8909

Open
tyrasd opened this issue Jan 21, 2022 · 1 comment
Open

tagging schema: always load strings to matching presets version #8909

tyrasd opened this issue Jan 21, 2022 · 1 comment
Labels
enhancement An enhancement to make an existing feature even better

Comments

@tyrasd
Copy link
Member

tyrasd commented Jan 21, 2022

Given that iD loads the most recent version of the tagging presets and that strings/translations are fetched separately from the presets data. This is in general a good think. But when a new version is released, it could be the case that a browser (or a CDN) has some of these files still cached (at the state of an older version) and fetches the remaining file freshly (at the state of the new version). This can lead to a situation where the files don't match properly, leading to symptoms like missing labels of new presets and fields.

In order to avoid this, iD should fetch the exact version of the id-tagging-schema first, and then fetch all data files with the exact full version. This will ensure that the versions of the files always are identical.

@tyrasd tyrasd added the enhancement An enhancement to make an existing feature even better label Jan 21, 2022
@andrewpmk
Copy link

Noticed this bug. name-suggestion-index etc. is being fetched from a hardcoded url from cdn.jsdelivr.net like https://cdn.jsdelivr.net/npm/name-suggestion-index@${vMinor}/dist/nsi.min.json. name-suggestion-index is constantly being updated and any new tagging presets won't be reflected in iD until you clear the cache or the cache expires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better
Projects
None yet
Development

No branches or pull requests

2 participants