Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance preset for leisure=horse_riding #9118

Closed
Hufkratzer opened this issue Apr 8, 2022 · 2 comments
Closed

Enhance preset for leisure=horse_riding #9118

Hufkratzer opened this issue Apr 8, 2022 · 2 comments
Labels
enhancement An enhancement to make an existing feature even better

Comments

@Hufkratzer
Copy link

Hufkratzer commented Apr 8, 2022

1. Rename preset to Horseback Riding Center

I think it is better to name this preset Horseback Riding Center instead of Horseback Riding Facility because:

Corresponding JOSM request is here.

2. Change background color for icon

I think the gray background color for the icon of the Horseback Riding Facility preset may arouse false associations and be inappropriate:
hbrfcolor2

I think the color that is used for the icon in the Farmyard preset might be more appropriate.

Related: openstreetmap/id-tagging-schema#273 (already done)

@Hufkratzer Hufkratzer changed the title Change background color for icon of Horseback Riding Facility Enhance preset for leisure=horse_riding Apr 25, 2022
@tyrasd tyrasd added the enhancement An enhancement to make an existing feature even better label May 13, 2022
tyrasd referenced this issue in openstreetmap/id-tagging-schema May 20, 2022
@tyrasd
Copy link
Member

tyrasd commented May 20, 2022

  1. was fixed in openstreetmap/id-tagging-schema@2be67fd
  2. will need to be adjusted in iD's code (the colors are essentially defined by how the features are rendered on the map) – I'll move the issue to iD's issue tracker

@tyrasd tyrasd transferred this issue from openstreetmap/id-tagging-schema May 20, 2022
@Hufkratzer
Copy link
Author

Then I close this in the hope that one day the background color will improve automatically. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better
Projects
None yet
Development

No branches or pull requests

2 participants