Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Mark as covered. #9290

Open
EvanCarroll opened this issue Sep 11, 2022 · 3 comments
Open

Feature Request: Mark as covered. #9290

EvanCarroll opened this issue Sep 11, 2022 · 3 comments

Comments

@EvanCarroll
Copy link

EvanCarroll commented Sep 11, 2022

Description

This is very annoying for me.

Screenshot_2022-09-11_11-06-08

This is caused by placing sidewalks, or drive through under roofs or carports.

s

What you have to do currently is break the sidewalk, and mark the part under as "covered=yes"

solved

  • 80% of the time, I get this box I want "connect the features".
  • 10% of the time, I get this box I want "make it a bridge"
  • 10% of the other time, I get this box I want "mark as covered."

This "mark as covered" on footpaths and sidewalks and drive-through, and driveways would make it such that, for my workload, ALL manual intervention could be one-click.

@EvanCarroll
Copy link
Author

EvanCarroll commented Sep 11, 2022

I think too you can make the argument that this isn't just convince but more correct. The layer documentation says this,

With some exceptions, layer=* on way ways should be used only in combination with one of tunnel=, bridge=, highway=steps, highway=elevator, covered=* or indoor=yes. For area areas, it could be used in combination with tags such as man_made=bridge, special types of building=* and similar.

So the thing made easy, currently, is to tag the car port as layer=1, which then allows you to save. But that's likely not correct unless it is an "exception". The general rule seems to be use covered=yes, at the least. Potentially in combination with a layer.

But it also seems like allowing layer=1 on a building is generally not a good idea, also a quote from the wiki,

special types of building=* and similar. [...] Ways in buildings (or similar structures like multi-level parking lots, shopping centers, airports, railway stations, some multi-level bridges and roads...) should be mostly described with level= instead of layer.*

I think as a general rule, you should not have a layer=1 to put a road under a regular mundane building, carport, or roof. Though easy with iD, this seems to be lacking in correctness.

@1ec5
Copy link
Collaborator

1ec5 commented Sep 11, 2022

The bit about level refers to hallways (highway=corridor), parking lot aisles inside a parking garage, etc., as opposed to roads that happen to go under a canopy. Note that the Roof preset also adds layer=1.

@EvanCarroll
Copy link
Author

EvanCarroll commented Sep 11, 2022

Ok, so it sounds like we need to figure out whether or not what is being done is advisable,

  • If roofs are layer=1, should carports also be that, since they're essentially roofs you park under?
    • If so, should sidewalks under carports not be marked as covered=yes? And if they shouldn't be marked as covered=yes should we allow people to save if there is a roof without a layer, and the sidewalk under it covered=yes? If so, I've done a lot of them wrong =(
    • If they should be marked as covered=yes, should we make it easier in one-click action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants