Wikiproject translation missing

[cotesta]

URL

https://www.openstreetmap.org/edit#map=18/39.93830/-81.92419

How to reproduce the issue?

1. Open OSM website, click edit
2. Make a change within the state of Ohio (possibly other states involved?)
3. Upload change, look to the left sidebar
   (still not fixed as of 6/24/2023)

Screenshot(s) or anything else?

WikiProject text is missing its en translation. Should be self-explanatory from screenshot.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.25.2

Which browsers are you seeing this problem on?

Firefox

[1ec5]

This issue also affects a few other resources, such as Code for San José Discord: osmlab/osm-community-index#654.

It appears to be a race condition of sorts. osm-community-index v5.5.3 was released a few days ago, including osmlab/osm-community-index#660. However, there hasn’t been a release of iD since April, so the base English localization file probably doesn’t contain the English text that’s in osm-community-index.

iD does fetch the latest osm-community-index v5.5.x dynamically at runtime to get the freshest list of resources to display:

iD/config/id.js

Line 7 in 446133d

|| 'https://cdn.jsdelivr.net/npm/osm-community-index@{version}/';

iD/modules/core/file_fetcher.js

Lines 14 to 16 in 446133d

	const ociVersion = packageJSON.dependencies['osm-community-index'] || packageJSON.devDependencies['osm-community-index'];
	const v = parseVersion(ociVersion);
	const ociVersionMinor = `${v.major}.${v.minor}`;

iD/package.json

Line 112 in 446133d

"osm-community-index": "~5.5.2",

However, the translated strings are baked into one of the files in /dist/locales/. In the case of English, the locale file is generated at build time based on whichever osm-community-index version was current at that time:

iD/modules/ui/success.js

Lines 171 to 173 in 446133d

	// Resolve strings
	const localizer = (stringID) => t.html(`community.${stringID}`);
	resource.resolved = resolveStrings(resource, oci.defaults, localizer);

iD/scripts/build_data.js

Line 194 in 446133d

const readCommunity = fs.readFileSync('node_modules/osm-community-index/i18n/en.yaml', 'utf8');

iD/package.json

Line 112 in 446133d

"osm-community-index": "~5.5.2",

I think the success screen needs to use a custom localizer that uses what fileFetcher pulls in. Or maybe the localization file’s community tree needs to be added to this table of trees to fetch dynamically, just like for id-tagging-schema:

iD/modules/core/localizer.js

Lines 91 to 103 in 446133d

	const localeDirs = {
	general: 'locales',
	tagging: presetsCdnUrl + 'dist/translations'
	};
	let fileMap = fileFetcher.fileMap();
	for (let scopeId in localeDirs) {
	const key = `locales_index_${scopeId}`;
	if (!fileMap[key]) {
	fileMap[key] = localeDirs[scopeId] + '/index.min.json';
	}
	filesToFetch.push(key);
	}