Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert non-standard dashes to standard dashes in the Opening Hours field #9735

Open
RedAuburn opened this issue Jul 6, 2023 · 1 comment
Labels
validation An issue with the validation or Q/A code

Comments

@RedAuburn
Copy link

URL

https://www.openstreetmap.org/changeset/138191928

How to reproduce the issue?

Upload opening hours using a non-standard dash

the standard dash seems to be - (Hyphen-Minus)
other similar dashes:
HYPHEN
NON-BREAKING HYPHEN
FIGURE DASH
EN DASH
SMALL EM DASH
۔‎ ARABIC FULL STOP
HYPHEN BULLET
˗ MODIFIER LETTER MINUS SIGN
MINUS SIGN
HEAVY MINUS SIGN
COPTIC CAPITAL LETTER DIALECT-P NI
(similar characters found from https://www.unicode.org/Public/security/15.0.0/confusables.txt, there may be more)

this leads to parsing fails in some applications, eg. also see organicmaps/organicmaps#3888. it should also be handled at the application level, but it's good to have standard data as well.

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

@1ec5
Copy link
Collaborator

1ec5 commented Jul 6, 2023

This should be possible to do without introducing a full-fledged parser for the opening hours syntax, which would be part of #974. Note that we probably shouldn’t be messing with anything inside "comments".

@nickrsan nickrsan added the validation An issue with the validation or Q/A code label Jul 6, 2023
@1ec5 1ec5 changed the title convert non-standard dashes to standard dashes convert non-standard dashes to standard dashes in the Opening Hours field Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants