Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spa for shop=beauty match is really late despite being an exact one #9560

Open
matkoniecz opened this issue Mar 23, 2023 · 3 comments
Open
Labels
usability An issue with ease-of-use or design

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Mar 23, 2023

And "wellness spa" matches nothing

https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/shop/beauty.json#L12

screen

see also https://community.openstreetmap.org/t/how-you-tag-spa-wellness-spa/97239

@matkoniecz matkoniecz changed the title wellness spa / spa = shop=beauty match is really late despite being an exact one spa for shop=beauty match is really late despite being an exact one Mar 23, 2023
@tyrasd tyrasd transferred this issue from openstreetmap/id-tagging-schema Mar 24, 2023
@tyrasd
Copy link
Member

tyrasd commented Mar 24, 2023

this is actually "a feature": partial matches on preset's name or aliases are sorted before exact or partial matches in search terms. This is because search terms are handled much more liberally and often include short phrases which would collide with the name of other presets.

I agree that the current sorting is not quite good, especially seeing the relatively large amount of partial matches of brand names. 😒

Perhaps it could make sense to rank partial brand name matches lower than exact matches in search terms? 🤔

@tyrasd tyrasd added the usability An issue with ease-of-use or design label Mar 24, 2023
@matkoniecz
Copy link
Contributor Author

It seems that problem is in general complex and fixing this case may break another. Are there test cases for search result ranking? That would prevent fixing one issue and breaking another and going in a cycle.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Mar 24, 2023

Perhaps it could make sense to rank partial brand name matches lower than exact matches in search terms? thinking

Sounds good to me

And also spaceport should rank lower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants