Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translatable strings to bridge field #1002

Merged
merged 1 commit into from Feb 26, 2024
Merged

Conversation

kjonosm
Copy link
Contributor

@kjonosm kjonosm commented Sep 9, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

馃嵄 Preview the tagging presets of this pull request here: https://pr-1002--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@kjonosm
Copy link
Contributor Author

kjonosm commented Feb 11, 2024

Hi @tyrasd, would you be able to review this pr?

@tyrasd
Copy link
Member

tyrasd commented Feb 26, 2024

Thank you, this looks good to me. It's only a bit unfortunate that this only applies to the Bridge Type field for the preset man_made=bridge and not for for selecting the type of bridge in the structure field which is used on all highway presets for example. That would need to be addressed separately, however, as it would involve adjusting some code in iD and likely also the tagging schema's json schema.

@tyrasd tyrasd merged commit 9b7e616 into openstreetmap:main Feb 26, 2024
5 checks passed
@kjonosm kjonosm deleted the patch-39 branch February 26, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants